Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low Power Mode Alert #527

Merged
merged 3 commits into from Dec 5, 2022
Merged

Low Power Mode Alert #527

merged 3 commits into from Dec 5, 2022

Conversation

IsaacMarovitz
Copy link
Member

No description provided.

@Depal1
Copy link
Member

Depal1 commented Nov 20, 2022

If this is to be done, it should only show for specific models since always plugged models don’t have a low power mode.

@Depal1
Copy link
Member

Depal1 commented Nov 20, 2022

At present, I don’t know how would it behave on the aforementioned Macs.

@FlyMeToTheMoonAndLetMePlayAmongTheStars

At present, I don’t know how would it behave on the aforementioned Macs.

Would it just open normally if there is no low power mode support?

@IsaacMarovitz
Copy link
Member Author

At present, I don’t know how would it behave on the aforementioned Macs.

For Macs that don't have a Low Power Mode, I imagine the bool is just always set to false.

@KhoraLee
Copy link
Contributor

KhoraLee commented Dec 5, 2022

At present, I don’t know how would it behave on the aforementioned Macs.

It's old and iOS documentation but it is still linked in latest apple's developer documentation page. So it should be applied to mac too.
https://developer.apple.com/library/archive/documentation/Performance/Conceptual/EnergyGuide-iOS/LowPowerMode.html#//apple_ref/doc/uid/TP40015243-CH31

If the device’s power state is unknown or if the device doesn’t support Low Power Mode, then this property always has a value of NO.

This reverts commit e235094.
@Depal1 Depal1 merged commit 0eca572 into PlayCover:develop Dec 5, 2022
@IsaacMarovitz IsaacMarovitz deleted the build-num branch January 18, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants