Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary App Icon Default #656

Merged
merged 1 commit into from Dec 30, 2022
Merged

Primary App Icon Default #656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions PlayCover/Utils/Cacher.swift
View file
Open in desktop
Expand Up @@ -27,6 +27,18 @@ class Cacher {
func resolveLocalIcon(_ app: PlayApp) -> NSImage? {
var bestResImage: NSImage?
let compareStr = app.info.bundleIdentifier + app.info.bundleVersion

do {
try app.url.enumerateContents { file, _ in
if file.lastPathComponent.contains(app.info.primaryIconName), let icon = NSImage(contentsOf: file),
checkImageDimensions(icon, bestResImage) {
bestResImage = icon
}
}
} catch {
Log.shared.error(error)
}

IsaacMarovitz marked this conversation as resolved.
Show resolved Hide resolved
if let assetsExtractor = try? AssetsExtractor(appUrl: app.url) {
for icon in assetsExtractor.extractIcons() where checkImageDimensions(icon, bestResImage) {
bestResImage = icon
Expand Down