Keymapping module architectural refactor #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2023
IsaacMarovitz
approved these changes
Sep 20, 2023
This comment was marked as spam.
This comment was marked as spam.
|
Hi @XuYicong you can use excalidraw or tldraw for diagrams. I'm sure both of these tools will be useful for you in the future. |
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A giant step towards fixing any keymapping bug, trust me bro(
So finally we have some software diagrams. We have class inheritance graph, state transition graph and data flow diagram. By the way, anyone knows a better diagram tool than a crowded draft paper?
Data Flow Diagram: (What happens when you press any key in game)
Class Inheritance Graph: (Different event adapters for different device and different control mode)
State Transition Graph: (Smart Keymapping corresponds to Click state. When that is disabled, only three states: Off, Editor and Camera)
