Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smart keymapping disallowing textfield typing #131

Conversation

TheMoonThatRises
Copy link
Member

@TheMoonThatRises TheMoonThatRises commented Nov 5, 2023

Fixes bug where smart keymapping makes it so that the user is unable to type in textfields (such as game chat) with smart keymapping enabled. Also fixes an issue where elements on screen are unable to be clicked. Fixes PlayCover/PlayCover#1086.

@XuYicong
Copy link
Member

XuYicong commented Nov 9, 2023

There are actually two classes conforming to the UITextInput protocol. I think it would be better to observe both their notifications.

also fixed some naming for clarity
@JoseMoreville
Copy link
Member

Testing today

@JoseMoreville JoseMoreville merged commit c22ec61 into PlayCover:3.0.0-staging Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Smart Keymap is broken
3 participants