Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle for scroll wheel #132

Merged
merged 7 commits into from Dec 4, 2023

Conversation

ytai-chn
Copy link
Contributor

@ytai-chn ytai-chn commented Nov 12, 2023

In Genshin Impact, the scroll wheel may cause some bugs:

  1. If you use the scroll wheel to the maximum, it will trigger an unexpected camera lock. As the video says, the character moves but the camera locks.
  2. When playing games with the touchpad, sometimes I will be stuck in a zoom-only perspective, and at this time, you can no longer rotate the camera but only zoom-in & zoom-out.
    After turning off the wheel mapping, the above bugs do not reappear, so I added a toggle to control the scroll wheel mapping. Another PR in playcover repo: Add toggle for scroll wheel  PlayCover#1215

After investigating, I found that this is related to inertial scrolling in Mac, but I find no solution to fix this issue in code.:(

QQ20231113-000504.mp4

@RellikJaeger

This comment has been minimized.

@AkshayanSingla

This comment has been minimized.

@RellikJaeger

This comment has been minimized.

@XuYicong XuYicong merged commit c7adf5d into PlayCover:3.0.0-staging Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants