PlayChain keychain emulation support #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depal1
reviewed
Jan 17, 2023
KhoraLee
reviewed
Jan 17, 2023
This reverts commit 992e860 due to it storing the keychain inside the app container instead of PlayCover's
IsaacMarovitz
requested changes
Jan 18, 2023
PlayTools.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
IsaacMarovitz
approved these changes
Jan 19, 2023
Depal1
approved these changes
Jan 21, 2023
IsaacMarovitz
pushed a commit
to IsaacMarovitz/PlayTools
that referenced
this pull request
Mar 16, 2023
* feat: Apple Keychain Emulation (beta) * feat: Make PlayChain optional * fix: Store Keychains in PlayCover directories * fix: remove more logging when debug isn't enabled * fix: trailing space after keychainFolder * fix: cleanup logging functions * fix: use debugLogger from PlayKeychain instead of redefining it * fix: correctly return NotFound for non supported types * fix: Nicer keychainFolder * Revert "fix: Nicer keychainFolder" This reverts commit 992e860 due to it storing the keychain inside the app container instead of PlayCover's * fix: team IDs and logging * fix: indentations * fix: tighter checks for Update operations * fix: remove Package.resolved
IsaacMarovitz
pushed a commit
to IsaacMarovitz/PlayTools
that referenced
this pull request
May 8, 2023
* feat: Apple Keychain Emulation (beta) * feat: Make PlayChain optional * fix: Store Keychains in PlayCover directories * fix: remove more logging when debug isn't enabled * fix: trailing space after keychainFolder * fix: cleanup logging functions * fix: use debugLogger from PlayKeychain instead of redefining it * fix: correctly return NotFound for non supported types * fix: Nicer keychainFolder * Revert "fix: Nicer keychainFolder" This reverts commit 992e860 due to it storing the keychain inside the app container instead of PlayCover's * fix: team IDs and logging * fix: indentations * fix: tighter checks for Update operations * fix: remove Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR propose a new feature that allows apps with PlayTools installed to partially use an Apple Keychain-like APIs to store secrets the same way they usually do. This mitigates the need to relax AMFI for keychain operations