Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using EOS_DISABLE define #653

Closed
BestStream opened this issue May 7, 2024 · 4 comments · Fixed by #662
Closed

Error when using EOS_DISABLE define #653

BestStream opened this issue May 7, 2024 · 4 comments · Fixed by #662
Assignees
Labels
bug Something isn't working build Changes that are related to CI/CD or generally the build process.

Comments

@BestStream
Copy link

Error when using EOS_DISABLE define:
Library/PackageCache/com.playeveryware.eos@74682501a1/Runtime/macOS/Core/MacOSPlatformSpecifics.cs(47,43): error CS0246: The type or namespace name 'PlatformSpecifics<>' could not be found (are you missing a using directive or an assembly reference?)

@paulhazen paulhazen self-assigned this May 7, 2024
@paulhazen
Copy link
Collaborator

We will either ship a hotfix for this release today - or make the change as part of our next release that should be coming within the week. For the time being, you should be able to resolve the issue by surrounding the MacOSPlatformSpecifics class definition with

#if !EOS_DISABLE
/* ... */
#endif

@paulhazen paulhazen added bug Something isn't working build Changes that are related to CI/CD or generally the build process. labels May 7, 2024
@paulhazen
Copy link
Collaborator

@andrew-hirata-playeveryware, @arthur740212 Do y'all have thoughts on whether we should do a hotfix or fix it in the next release?

@andrew-hirata-playeveryware
Copy link
Collaborator

I think in this case, it is better to wait for a new release.

@paulhazen
Copy link
Collaborator

Closing because this has been resolved in development with PR #662. The change will be included in our upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Changes that are related to CI/CD or generally the build process.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants