fix: Properly support behavior when EOS_DISABLE is defined.
#662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, and shortened lines for readability.
…pport scenarios where the scripting define EOS_DISABLE is defined in Player Settings.
paulhazen
added
the
build
paulhazen
requested review from
WispyMouse,
arthur740212 and
andrew-hirata-playeveryware
andrew-hirata-playeveryware
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some circumstances (some build configurations) if the scripting define
EOS_DISABLEhas been added within the Player Settings window of the Unity project, compilation errors will result.This PR represents changes that affect the correct implementation of that define. Along the way, missing comments were added to the
IOSBuilderclass, and some very minor formatting changes were made to increase readability.This closes issue #653.