The C++ SDK is writing its log file to the wrong folder

[stkrwork]

Describe the bug
The C++ SDK is writing its log file to the wrong folder. The log file is not in the folder specified, but next to the folder

To Reproduce
Steps to reproduce the behavior:

1. Log a message with the log functionality of the C++ SDK
2. Observe that the log file is not in the folder specified, but next to the folder

Expected behavior
the log file should be inside that folder not next to it.

Screenshots

Desktop (please complete the following information):

• C++ SDK

Fix idea
Either add a slash here or the config value LOG_FOLDER_KEY ("logFolder") needs to get a slash appended in the end

[dgkanatsios]

thanks @stkrwork!
so @ravarnamsft did some investigation and the bug exists for process based servers. For process based servers we don't add the "/" at the end of the env variable whereas we add it on container based servers. In C# and Java GSDK we do use methods that concatenate folder and paths correctly (e.g. the Path.Combine method here

gsdk/csharp/GSDK_CSharp_Standard/FilesystemLogger.cs

Line 54 in a329d1b

string fileName = Path.Combine(_logFolder, $"GSDK_output_{datePart}.txt");

), we could do the same for C++.

[stkrwork]

this could be an option, to detect if it ends with a slash or not, and then add one to the end if needed before appending the file name