Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.net 6 for .NET sample and open arena #112

Merged
merged 1 commit into from
Dec 16, 2021
Merged

.net 6 for .NET sample and open arena #112

merged 1 commit into from
Dec 16, 2021

Conversation

dgkanatsios
Copy link
Collaborator

Signed-off-by: Dimitrios Ilias Gkanatsios dgkanatsios@outlook.com

Converting netcore sample and openarena to work with .NET 6. Moreover, removing the x64 build from the botnet publish command. This has the effect of building for whatever architecture the container is running on, enabling the end to end tests to run on MacOS with M1 (Apple Silicon) processor.

Signed-off-by: Dimitrios Ilias Gkanatsios <dgkanatsios@Dimitrioss-MacBook-Air.local>
@dgkanatsios dgkanatsios added the enhancement New feature or request label Dec 16, 2021
Copy link
Collaborator

@khaines khaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I ran this branch on my M1 mac for E2E tests and they passed

@khaines khaines merged commit d4bd27a into master Dec 16, 2021
@khaines khaines deleted the net6 branch December 16, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants