Attempt to fix the unit test bug #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgkanatsios
force-pushed
the
fixunhealthy
branch
from
931b818
to
a3daffc
Compare
dgkanatsios
force-pushed
the
fixunhealthy
branch
from
a3daffc
to
1294395
Compare
khaines
reviewed
Dec 29, 2021
cmd/e2e/utilities.go
Outdated
| @@ -191,6 +191,13 @@ func verifyGameServerBuild(ctx context.Context, buildID, buildName string, state | |||
| return fmt.Errorf("expected %d crashes, got %d", state.crashesCount, gameServerBuild.Status.CrashesCount) | |||
| } | |||
|
|
|||
| // 5 is the default, we should parameterize that | |||
| if gameServerBuild.Status.CrashesCount >= 5 && gameServerBuild.Status.Health != "Unhealthy" { | |||
| return fmt.Errorf("expected %s health, got %s", "Unhealthy", gameServerBuild.Status.Health) | |||
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("expected %s health, got %s", "Unhealthy", gameServerBuild.Status.Health) | |
| return fmt.Errorf("expected %s status, got %s", "Unhealthy", gameServerBuild.Status.Health) |
khaines
reviewed
Dec 29, 2021
cmd/e2e/utilities.go
Outdated
| if gameServerBuild.Status.CrashesCount >= 5 && gameServerBuild.Status.Health != "Unhealthy" { | ||
| return fmt.Errorf("expected %s health, got %s", "Unhealthy", gameServerBuild.Status.Health) | ||
| } else if gameServerBuild.Status.CrashesCount < 5 && gameServerBuild.Status.Health != "Healthy" { | ||
| return fmt.Errorf("expected %s health, got %s", "Healthy", gameServerBuild.Status.Health) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("expected %s health, got %s", "Healthy", gameServerBuild.Status.Health) | |
| return fmt.Errorf("expected %s status, got %s", "Healthy", gameServerBuild.Status.Health) |
khaines
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118