Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing gs.Spec.PodSpec to PodTemplateSpec #127

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Conversation

dgkanatsios
Copy link
Collaborator

@dgkanatsios dgkanatsios commented Jan 7, 2022

Fixes #105

This PR should be merged just before we ship 0.2.0, since it will change all the sample yaml files unfortunately.

This PR alters GameServerBuild to accept PodTemplateSpec instead of PodSpec. This will allow the user to set custom Labels and Annotations for their Pods (PodTemplateSpec contains ObjectMeta whereas PodSpec does not). Other fields on the PodTemplateSpec are ignored.

@dgkanatsios dgkanatsios added area/user-experiences Developer experience and suggestions on how to use thundernetes, installation, getting up & running breaking change labels Jan 7, 2022
@dgkanatsios dgkanatsios marked this pull request as ready for review January 7, 2022 21:24
@ravarnamsft
Copy link

                                exec:

Does all of this get autogenerated? Otherwise, it's a lot of things to review


Refers to: pkg/operator/config/crd/bases/mps.playfab.com_gameservers.yaml:1260 in 18d5660. [](commit_id = 18d5660, deletion_comment = False)

@dgkanatsios
Copy link
Collaborator Author

dgkanatsios commented Jan 12, 2022

Yes, the file that you refer to was auto generated!

Copy link

@ravarnamsft ravarnamsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dgkanatsios dgkanatsios merged commit f84b14f into master Jan 13, 2022
@dgkanatsios dgkanatsios deleted the podtemplatespec branch January 13, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experiences Developer experience and suggestions on how to use thundernetes, installation, getting up & running breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom Labels and Annotations to the game server Pods
3 participants