creating/deleting gameservers in batch #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgkanatsios
force-pushed
the
batchcreategameservers
branch
from
bb2d2a7
to
f181693
Compare
dgkanatsios
force-pushed
the
batchcreategameservers
branch
10 times, most recently
from
9a7eb7d
to
3b8c843
Compare
dgkanatsios
force-pushed
the
batchcreategameservers
branch
from
3b8c843
to
e629964
Compare
khaines
approved these changes
Jan 31, 2022
| @@ -60,6 +58,11 @@ var gameServersUnderDeletion = sync.Map{} | |||
| // concurrent since the reconcile loop can be called multiple times for different GameServerBuilds | |||
| var crashesPerBuild = sync.Map{} | |||
|
|
|||
| const ( | |||
| maxNumberOfGameServersToAdd = 20 | |||
There was a problem hiding this comment.
Nit: Maybe a todo here to remind us to make these overridable in the future? 20 is a great default, but their may be cases where someone will want to change this without changing the source code :)
There was a problem hiding this comment.
I’ll make an issue for that, good call!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138 and #141
Due to the fact that GameServerBuild controller calls .Create(newGameServer) synchronously, the controller is blocked when there are multiple GameServers waiting to be created (or deleted). This PR fixes that by creating/deleting GameServers in batches of 20. Help was provided in this issue: kubernetes-sigs/controller-runtime#1782
Also moving resource requests/limits for the sample on a different sample file, so to assist with local development and scaling tests.