Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding resources for samples #15

Merged
merged 3 commits into from
Oct 13, 2021
Merged

adding resources for samples #15

merged 3 commits into from
Oct 13, 2021

Conversation

dgkanatsios
Copy link
Collaborator

This PR

  • makes requests/limits equal for the controller Pod, as recommended for production Kubernetes workloads
  • adds requests/limits for the samples

khaines
khaines reviewed Oct 12, 2021
View reviewed changes
operator/config/manager/manager.yaml Outdated
@@ -59,8 +59,8 @@ spec:
periodSeconds: 10
resources:
requests:
cpu: 100m
memory: 100Mi
cpu: 500m
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPU is probably the more constrained resource if someone is trying to run this on Kind. If this can work with 100m as a starting point, perhaps we should set it to that level for request/limit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the feedback! Do you recommend similar changes on the samples as well?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would. Generally samples and "getting started" kind of content you want to have as low resource reservation as possible, so people can run it on their local machines. If there are resource recommendations for running this in a deployed kube cluster, that can be commented line in the same file or as a separate markdown text.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated, thanks again!

@dgkanatsios dgkanatsios self-assigned this Oct 12, 2021
@dgkanatsios dgkanatsios added the documentation Improvements or additions to documentation label Oct 13, 2021
khaines
khaines approved these changes Oct 13, 2021
View reviewed changes
Copy link
Collaborator

@khaines khaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , thank you for making the updates

@dgkanatsios dgkanatsios merged commit ad3f6bd into master Oct 13, 2021
@dgkanatsios dgkanatsios deleted the dev/digkanat/addresourcesforpods branch October 13, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaines khaines khaines approved these changes

Assignees

@dgkanatsios dgkanatsios

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dgkanatsios @khaines