Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making tests parallel #165

Merged
merged 2 commits into from
Feb 17, 2022
Merged

making tests parallel #165

merged 2 commits into from
Feb 17, 2022

Conversation

dgkanatsios
Copy link
Collaborator

@dgkanatsios dgkanatsios commented Feb 10, 2022 •
edited

Closes #1

This PR completely upgrades the end to end test infrastructure by utilizing ginkgo/gomega libraries and parallelism.
Also:

  • upgrading e2e kind cluster to Kubernetes 1.22.5
  • increasing the resource limits/requests of the controller since they were too low
  • fixing an issue on the GameServerBuild controller where it would ignore downscaling if the GameServerBuild has GameServers stuck in initializing (corner case but still)
  • modifies a GameServerBuild controller unit test to use .Patch instead of .Update (it would rarely create conflicts)

@dgkanatsios dgkanatsios force-pushed the paralleltests1 branch 14 times, most recently from 3d77bbe to 5aca216 Compare February 11, 2022 08:15
@dgkanatsios dgkanatsios marked this pull request as ready for review February 11, 2022 08:26
@dgkanatsios dgkanatsios force-pushed the paralleltests1 branch 2 times, most recently from 3ced150 to a7cbf9c Compare February 11, 2022 18:18
khaines
khaines reviewed Feb 16, 2022
View reviewed changes
e2e/run.sh Outdated Show resolved Hide resolved
khaines
khaines approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@khaines khaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for this change @dgkanatsios ! this really helps running the tests quickly

@dgkanatsios dgkanatsios merged commit a4a9f70 into master Feb 17, 2022
@dgkanatsios dgkanatsios deleted the paralleltests1 branch February 17, 2022 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaines khaines khaines approved these changes

@AmieDD AmieDD Awaiting requested review from AmieDD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make e2e tests run in parallel
2 participants
@dgkanatsios @khaines