Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test allocate wrong tls credentials #200

Merged
merged 4 commits into from
Mar 30, 2022
Merged

Test allocate wrong tls credentials #200

merged 4 commits into from
Mar 30, 2022

Conversation

javier-op
Copy link
Contributor

Added a test that checks that you can't allocate gameservers when using a wrong TLS certificates.

@ghost
Copy link

ghost commented Mar 30, 2022 •
edited by ghost

CLA assistant check
All CLA requirements met.

@AmieDD AmieDD self-requested a review March 30, 2022 20:47
AmieDD
AmieDD approved these changes Mar 30, 2022
View reviewed changes
Copy link
Collaborator

@AmieDD AmieDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @javier-op! 🦄

@javier-op javier-op merged commit 1270a24 into main Mar 30, 2022
@javier-op javier-op deleted the test_allocate_wrong_tls_cred branch March 30, 2022 20:56
@dgkanatsios dgkanatsios mentioned this pull request Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmieDD AmieDD AmieDD approved these changes

@dgkanatsios dgkanatsios dgkanatsios approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@javier-op @AmieDD @dgkanatsios