Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark GameServers as unhealthy when no heartbeats are received #236

Merged
merged 17 commits into from
Apr 29, 2022
Merged

Mark GameServers as unhealthy when no heartbeats are received #236

merged 17 commits into from
Apr 29, 2022

Conversation

javier-op
Copy link
Contributor

Fixes #225

dgkanatsios
dgkanatsios reviewed Apr 26, 2022
View reviewed changes
cmd/nodeagent/nodeagentmanager.go Outdated Show resolved Hide resolved
cmd/nodeagent/nodeagentmanager.go Outdated Show resolved Hide resolved
cmd/nodeagent/nodeagentmanager.go Outdated Show resolved Hide resolved
cmd/nodeagent/nodeagentmanager_test.go Outdated Show resolved Hide resolved
dgkanatsios
dgkanatsios approved these changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@dgkanatsios dgkanatsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@javier-op javier-op merged commit 38b9c45 into main Apr 29, 2022
@javier-op javier-op deleted the mark_gs_unhealthy_when_no_heartbeats branch April 29, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgkanatsios dgkanatsios dgkanatsios approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GameServers that don’t send a heartbeat for X seconds should be marked as Unhealthy
2 participants
@javier-op @dgkanatsios