checking if make create-install-files makes the repo dirty #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgkanatsios
force-pushed
the
checkgitdirty
branch
2 times, most recently
from
aac7c46
to
cc66bf7
Compare
dgkanatsios
force-pushed
the
checkgitdirty
branch
from
cc66bf7
to
8bd8118
Compare
javier-op
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134
This PR adds an extra step into our CI pipeline where it will generate the install files (
make create-install-files) and then check if the repo has been dirty. This is for cases where we upgrade dependent libraries (e.g. controller-runtime) and this will change the YAML generated files that our operator is based on. In these cases, we should create a new Thundernetes version.