Deleting Unhealthy game servers #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgkanatsios
force-pushed
the
deleteunhealthy
branch
from
047f8dd
to
f111188
Compare
dgkanatsios
force-pushed
the
deleteunhealthy
branch
2 times, most recently
from
bd5984d
to
54cfd3b
Compare
javier-op
reviewed
Jun 14, 2022
javier-op
reviewed
Jun 14, 2022
javier-op
reviewed
Jun 14, 2022
dgkanatsios
force-pushed
the
deleteunhealthy
branch
3 times, most recently
from
fedf271
to
912c966
Compare
dgkanatsios
force-pushed
the
deleteunhealthy
branch
7 times, most recently
from
fd43382
to
3093278
Compare
javier-op
approved these changes
Jun 16, 2022
dgkanatsios
force-pushed
the
deleteunhealthy
branch
2 times, most recently
from
d1772a0
to
c3a451f
Compare
dgkanatsios
force-pushed
the
deleteunhealthy
branch
from
c3a451f
to
a0d9b3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56
This PR modifies the GameServerBuild controller to delete a GameServer when its status becomes Unhealthy.
As a side effect, we expect it to fix #256 and #257 since Unhealthy GameServers won't exist in the cluster any more so:
i) they won't be taken into account when scaling
ii) NodeAgent will get a notification about their deletion so it will not repeatedly try to mark them as Unhealthy
The change in the YAML files is probably due to the new C-R version that was merged in a different PR.