Various refactorings #353
Merged
Various refactorings #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgkanatsios
force-pushed
the
refactorings
branch
15 times, most recently
from
67452bf
to
70710ea
Compare
javier-op
reviewed
Jul 29, 2022
| // We use map[string]interface{} instead a []string to facilitate constant time lookups for GameServer names. | ||
| // On every reconcile loop, we check if all the GameServers for this GameServerBuild are present in cache) | ||
| // The controller code will eventually delete the extra GameServers, but we can improve this process. | ||
| // The solution is to create a synchonized map to track which objects were just created |
javier-op
reviewed
Jul 29, 2022
| // (synchronized since it might be accessed by multiple reconciliation goroutines - one for each GameServerBuild) | ||
| // In this map, the key is GameServerBuild.Name | ||
| // The value is a struct with map[string]interface{} and a mutex | ||
| // The map acts like a set which contains the GameServer.Name for all the GameServers under creation |
There was a problem hiding this comment.
it's a property :D let me make it more clear!
javier-op
approved these changes
Jul 29, 2022
dgkanatsios
force-pushed
the
refactorings
branch
from
70710ea
to
a08fc88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drafting a PR so we can run e2e tests here.