Removing finalizer from GameServer CR #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgkanatsios
force-pushed
the
removefinalizer
branch
4 times, most recently
from
158d7df
to
c4324a2
Compare
javier-op
reviewed
Sep 14, 2022
dgkanatsios
force-pushed
the
removefinalizer
branch
from
af8ac17
to
69930d8
Compare
javier-op
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #270
This PR removes the finalizer from GameServer CR. The finalizer was originally used to cleanup the port registry memory. We have switched the implementation to use the "notFound" event to cleanup the GameServer ports.
This is a breaking change.
After we merge it, we should do the following changes before releasing the next Thundernetes version.