Consolidation of Gauge metrics for simplicity. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt label values. Changed metric registration to use promauto, in order to skip the hassle of manual registration Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change consolidates a few discreet metrics into a consolidated time series, using a label to differentiate the different states. This actually makes the the dash board queries simpler, since the sum of the single metric is the total of all server states, while still being able to graph each state individually.
All metrics have been updated with a "thundernetes" namespace prefix for ease of discovery in tools like grafana.
Also streamlined the metrics registration by using the
promautolibrary of prometheus.I've separated out the grafana and prom operator changes to a different PR to keep things tidy.