init scale test framework #413
Conversation
Uses openarena as testing game server to test scalability * add functions to allocate new server from standby state and clear all active servers * add test cases regarding number of standby servers Signed-off-by: Allen Leigh <allenlsy@gmail.com>
|
LGTM! YAML files reference the same GameServerBuild, right? Any way we can use one of them and then do |
Signed-off-by: Allen Leigh <allenlsy@gmail.com>
tests/scalability/scale-test.sh
Outdated
| @@ -2,21 +2,21 @@ | |||
|
|
|||
| source ./util.sh | |||
|
|
|||
| GSID=85ffe8da-c82f-4035-86c5-9d2b5f42d6f7 | |||
| GSB_NAME=gameserverbuild-sample-openarena | |||
|
|
|||
| echo "test 1: scale up to 16 servers from 1 standby server" | |||
| kubectl apply -f ./standby/1.yaml | |||
There was a problem hiding this comment.
these kubectl apply commands are not valid anymore, right?
There was a problem hiding this comment.
It creates the gsb with 1 initial standby and 16 max. I think we still need it.
There was a problem hiding this comment.
oh, sorry, files were not visible and I thought they were deleted. Do we need all three of them now?
There was a problem hiding this comment.
I think we need, but it shouldn't be different initial standby. We actually need to test the scale time for different max.
There was a problem hiding this comment.
max in all three files is currently the same, 16. Plus, we can send a JSON patch via kubectl and change it dynamically if needed. Not a big deal TBH, I wouldn't block this PR for it.
There was a problem hiding this comment.
Updated test cases to use max as the variant.
tests/scalability/scale-test.sh
Outdated
|
|
||
| echo "test 1: scale up to 16 servers from 1 standby server" | ||
| kubectl apply -f ./standby/1.yaml | ||
| scale_up $GSID 16 | ||
| scale_up $GSB_NAME 16 | ||
| kubectl delete gsb gameserverbuild-sample-openarena |
There was a problem hiding this comment.
do we need to delete the build before scaling? we can downscale to zero if needed
There was a problem hiding this comment.
We can scale down to 0. Which one is more appropriate here?
There was a problem hiding this comment.
let's scale to zero, any chance we can wait till the actual standing by is zero?
* scale down to 0 servers instead of deleting gsb Signed-off-by: Allen Leigh <allenlsy@gmail.com>
Can you help update the PR description? I will add instructions to the readme, or a separate readme in this folder. |
|
apologies, I wasn't clear. You don't have to modify the PR description itself, just whatever you copy and paste into the README. Hope it makes sense now! |
Signed-off-by: Allen Leigh <allenlsy@gmail.com>
This PR is a starting point of scalability test.
It creates necessary functions to perform a simple test. It tests scaling up to 16 active gameservers from 1, 4, 16 standby servers respectively.
Uses openarena as testing game server to test scalability
scale_upandscale_clearto allocate new standing by servers. These method can also be used withoutscale-test.sh.standbymax serversAfter running
scale-test.sh, here is the result:Signed-off-by: Allen Leigh allenlsy@gmail.com