Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring & Grafana Updates #42

Merged
merged 8 commits into from Nov 8, 2021
Merged

Monitoring & Grafana Updates #42

merged 8 commits into from Nov 8, 2021

Conversation

khaines
Copy link
Collaborator

@khaines khaines commented Oct 24, 2021

This PR updates monitoring related files and the grafana dashboard:

  • Adds a metrics monitoring service definition to the controller (in cluster traffic only)
  • Renames the TLS based external facing service to be more apparent
  • Adds RBAC roles & role-binding examples for the default kube-prometheus operator, so that thundernetes is automatically discovered and readable with the prometheus service account.
  • Updates sample grafana dashboard for changes in metric naming from previous PR.

@AmieDD AmieDD added the enhancement New feature or request label Oct 27, 2021
@dgkanatsios dgkanatsios mentioned this pull request Oct 28, 2021
Closed
dgkanatsios
dgkanatsios approved these changes Nov 1, 2021
View reviewed changes
Copy link
Collaborator

@dgkanatsios dgkanatsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AmieDD AmieDD linked an issue Nov 3, 2021 that may be closed by this pull request
0.1.0 #47
Closed
@khaines
adding thundernetes namespace to front of app specific metrics.
6a28d2c 
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
@khaines
updating grafana sample for new metric names and labels
0a066be 
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
@khaines
adding service monitor roles & bindings for use by the kube-prometheu…
b13c530 
…s operator

Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
@khaines
PR Feedback
ded9ab0 
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
@khaines
updating install files with new/modified service definitions
b07f636 
Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
@khaines
adding separate install yaml files, to include prometheus operator su…
f04bb8d 
…pport

Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
@khaines
adjusting kustomize output for monitoring resources to have consisten…
2c2d552 
…t naming and namespaces

Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
@khaines
adjusting kustomize output for monitoring resources to have consisten…
3a0e850 
…t naming and namespaces

Signed-off-by: Ken Haines <1144092+khaines@users.noreply.github.com>
@khaines khaines force-pushed the khaines/grafana-prom-monitor-update branch from 92d9f5a to 3a0e850 Compare November 8, 2021 18:57
@khaines khaines merged commit 43e2ba1 into PlayFab:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgkanatsios dgkanatsios dgkanatsios approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.1.0
3 participants
@khaines @dgkanatsios @AmieDD