Better tracking ConnectedPlayers #48
Conversation
dgkanatsios
force-pushed
the
gameserverdetails
branch
from
14faeb0
to
f96aeea
Compare
dgkanatsios
added
area/tests
|
Some minor comments and nits, but otherwise LGTM! |
| metadata: | ||
| annotations: | ||
| controller-gen.kubebuilder.io/version: v0.4.1 | ||
| creationTimestamp: null |
There was a problem hiding this comment.
Nit: this field can be removed, since it is null.
There was a problem hiding this comment.
this is auto-generated when running make. Probably the controller-gen utility does it :(
sidecar-go/httphandler.go
Outdated
|
|
||
| fmt.Printf("Got values from allocation, sessionID:%s, sessionCookie:%s, initialPlayers:%#v\n", sessionID, sessionCookie, initialPlayers) | ||
| initialPlayers := h.getInitialPlayersDetails() | ||
| log.Infof("Got values from allocation, initialPlayers:%#v", initialPlayers) |
There was a problem hiding this comment.
You could be referencing a nil slice here, if there was an error in getInitialPlayerDetails
There was a problem hiding this comment.
ah gotcha - will this panic though?
There was a problem hiding this comment.
shouldn't, because you are looking at the slice itself, vs a property of it.
sidecar-go/httphandler.go
Outdated
| @@ -157,34 +183,41 @@ func (h *httpHandler) heartbeatHandler(w http.ResponseWriter, req *http.Request) | |||
| } | |||
|
|
|||
| if logEveryHeartbeat { | |||
| fmt.Printf("heartbeat received from sessionHostId %s, data %#v\n", sessionHostId, hb) | |||
| log.Infof("heartbeat received from sessionHostId %s, data %#v", sessionHostId, hb) | |||
There was a problem hiding this comment.
Suggestion: For outputing regular "succcess" or "it works" text, consider the debug severity. Info has always felt to me to be used for significant events in a system, which don't happen frequently.
There was a problem hiding this comment.
done. Should we have an env variable specifying the log level?
|
|
||
| func (h *httpHandler) updateConnectedPlayersCountIfNeeded(ctx context.Context, hb *HeartbeatRequest) error { |
There was a problem hiding this comment.
Having a player count metric exposed may be useful as well, so that prometheus can track and graph this in grafana. totally something that can be done in a follow on PR.
There was a problem hiding this comment.
awesome idea, created #49 to track
This PR does a bunch of things.
I also wanted to rename the httphandler struct and file as part of #37, but I'll do that on a separate PR, since this one is already big.