Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing GameServerBuild controller issues #95

Merged
merged 5 commits into from
Dec 4, 2021
Merged

fixing GameServerBuild controller issues #95

merged 5 commits into from
Dec 4, 2021

Conversation

dgkanatsios
Copy link
Collaborator

We discovered an issue where the GameServerBuild controller would stop execution if Pods would be stuck in a Pending state (e.g. if the cluster cannot host any more Pods). This PR fixes this issue.

@dgkanatsios dgkanatsios force-pushed the bugfixing branch 2 times, most recently from 22c1fc9 to 8e5ead8 Compare December 2, 2021 01:42
@dgkanatsios dgkanatsios force-pushed the bugfixing branch 3 times, most recently from b026d42 to 1e1558a Compare December 2, 2021 02:22
@dgkanatsios dgkanatsios added bug Something isn't working priority/high labels Dec 3, 2021
Copy link
Collaborator

@khaines khaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dgkanatsios dgkanatsios merged commit 0b69725 into master Dec 4, 2021
@dgkanatsios dgkanatsios deleted the bugfixing branch December 4, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants