Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing e2e tests #98

Merged
merged 1 commit into from
Dec 6, 2021
Merged

fixing e2e tests #98

merged 1 commit into from
Dec 6, 2021

Conversation

dgkanatsios
Copy link
Collaborator

Currently, during e2e tests we are "GETting" GameServerBuilds into the same variable. This has the unfortunate consequence of some GameServerBuilds getting overwritten (e.g. the "testBuild" had an unwanted env variable). This PR resets the variable before every "GET".

@dgkanatsios dgkanatsios added the bug Something isn't working label Dec 6, 2021
Copy link
Collaborator

@khaines khaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch & fix! LGTM

@dgkanatsios dgkanatsios merged commit c178613 into master Dec 6, 2021
@dgkanatsios dgkanatsios deleted the fixe2e branch December 6, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants