adding badges #5
Conversation
|
Changes Unknown when pulling 9d1c658 on v1.0.1 into ** on master**. |
1 similar comment
|
Changes Unknown when pulling 9d1c658 on v1.0.1 into ** on master**. |
|
Changes Unknown when pulling 4901076 on v1.0.1 into ** on master**. |
|
Changes Unknown when pulling 29f3ac9 on v1.0.1 into ** on master**. |
|
@brozeph yeah, looks like the report interpretation is different with coveralls since the coverage is above 80% while running the tests. |
|
Also, the build is failing as it is pointing to master and there is no code to build in master. Just to test, I changed the branch to v1.0.1 and that passes the build. Hence, once v1.0.1 is merged to master, build passes. |
|
Looking into why the coveralls reports less % code coverage. Also will look into bumping up the coverage. |
|
@brozeph added test that bumped code coverage above 90% |
|
Changes Unknown when pulling 20bbfd9 on v1.0.1 into ** on master**. |
We'll need to get coverage up - I haven't looked closely, but perhaps it's a weird issue with how coveralls interprets the reports.
Additionally, note the missing dependencies that were required to get the build to work properly. These little details are killers (https://travis-ci.org/PlayNetwork/fs-promise-util/jobs/231622328#L420).