fix: prevent request being serialized twice

[m-schmoock]

json-ipc-lib will make use of json-rpc-protocol module.
In its current form it already does a JSON.stringify inside the submodule.
Client.js tries this a second time, which will result in
a compliant server not understand the request.

{ Error: JSON-IPC Client Exception::Expected {} for json command
at Socket. (./node_modules/json-ipc-lib/dist/Client.js:171:36)
at Socket.emit (events.js:197:13)

Note:
This will not happen for 'method only' calls but for
'object' {method, params, ...} calls.

Relevant code snippets:

Client.js

import * as protocol from 'json-rpc-protocol';
// ...
protocol.format.request(
	Date.now(),
	method,
	args);
...
socket.write(JSON.strinify(request));

node_modules/json-rpc-protocol/dist/format.js

var toJson = JSON.stringify;
...
  return toJson({
    jsonrpc: '2.0',
    id,
    error: _error
  });

[brozeph]

Added #12 to stringify in the event the payload isn't a string... this should, in theory, fix the double stringify (and it passes unit testing)... not sure of the exact scenario you're running into, so this may not fully resolve. Any further hints or a test harness for validation would help too, if you can share... no worries if not.

[m-schmoock]

As I describe with the code samples above, we see that stringify will be called twice:

• first by protocol.format.request
• second by Client.js

This only happens for requests with pamaeters that are not just plain metho calls. If you need I write a test.

[m-schmoock]

But your fix does the same. thx

[brozeph]

Closing as merged and released v1.1.2 from other PR 🥂