Merge pull request #37 from PlayNetwork/v1.1.2

adding deleteSettings to settings sub-module
PlayNetwork · Dec 1, 2016 · 000e628 · 000e628
2 parents 672b2a0 + cab9a3e
commit 000e628
Show file tree

Hide file tree

Showing 4 changed files with 98 additions and 6 deletions.
diff --git a/history.md b/history.md
@@ -1,3 +1,7 @@
+# v1.1.2 - 2016/12/01
+
+* Added `deleteSettings` to `settings` sub-module
+
 # v1.1.1 - 2016/12/01
 
 * Added `upsertCollections` and `upsertStations` methods to `music` sub-module

diff --git a/lib/settings.js b/lib/settings.js
@@ -95,6 +95,36 @@ module.exports = function (settingsOptions, ensureAuthHeaders, self) {
 		return validation.promiseOrCallback(exec, callback);
 	};
 
+	self.deleteSettings = (alias, options, callback) => {
+		// handle any non-specified input params
+		if (typeof options === 'function') {
+			callback = options;
+			options = undefined;
+		}
+
+		if (typeof alias === 'function') {
+			callback = settingId;
+			alias = undefined;
+			options = undefined;
+		}
+
+		let exec = co(function *() {
+			if (validation.isEmpty(alias)) {
+				return yield Promise.reject(new Error('settings identifier is required'));
+			}
+
+			let headers = yield ensureAuthHeaders();
+
+			return yield req.delete({
+				headers : headers,
+				pathname : `/v0/settings/${alias}`,
+				query : options
+			});
+		});
+
+		return validation.promiseOrCallback(exec, callback);
+	};
+
 	self.getSettings = (alias, options, callback) => {
 		// handle any non-specified input params
 		if (typeof options === 'function') {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "playnetwork-sdk",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "contributors": [
     {
       "name": "Joshua Thomas",

diff --git a/test/lib/settings.js b/test/lib/settings.js
@@ -199,11 +199,6 @@ describe('settings', () => {
 	});
 
 	describe('#getSettings', () => {
-		// intercept outbound request
-		nock('https://curio-settings-api.apps.playnetwork.com')
-			.get('/v0/settings')
-			.reply(200, { });
-
 		it('should require setting identifer', (done) => {
 			settings.getSettings()
 				.then(() => {
@@ -250,6 +245,69 @@ describe('settings', () => {
 		});
 	});
 
+	describe('#deleteSettings', () => {
+		it('should require setting identifer', (done) => {
+			settings.deleteSettings()
+				.then(() => {
+					return done(new Error('should require settings identifier'));
+				})
+				.catch((err) => {
+					should.exist(err);
+					should.exist(err.message);
+					err.message.should.contain('settings identifier is required');
+
+					return done();
+				});
+		});
+
+		it('should properly delete settings (promise)', (done) => {
+			// intercept outbound request
+			nock('https://curio-settings-api.apps.playnetwork.com')
+				.delete('/v0/settings/test')
+				.reply(204);
+
+			settings.deleteSettings('test')
+				.then((result) => {
+					should.exist(result);
+					should.exist(requestInfo);
+
+					return done();
+				})
+				.catch((err) => (done(err)));
+		});
+
+		it('should properly delete settings (callback)', (done) => {
+			// intercept outbound request
+			nock('https://curio-settings-api.apps.playnetwork.com')
+				.delete('/v0/settings/test')
+				.reply(204);
+
+			settings.deleteSettings('test', function (err, result) {
+				should.not.exist(err);
+				should.exist(result);
+				should.exist(requestInfo);
+
+				return done();
+			});
+		});
+
+		it('should properly delete settings with options (promise)', (done) => {
+			// intercept outbound request
+			nock('https://curio-settings-api.apps.playnetwork.com')
+				.delete('/v0/settings/test?deviceToken=1')
+				.reply(204);
+
+			settings.deleteSettings('test', { deviceToken : 1 })
+				.then((result) => {
+					should.exist(result);
+					should.exist(requestInfo);
+
+					return done();
+				})
+				.catch((err) => (done(err)));
+		});
+	});
+
 	describe('#upsertSettings', () => {
 		let mockSetting = {
 			legacy : {