Merge pull request #79 from PlayNetwork/v1.4.5

fixing an issue where ensureAuthHeaders was not properly called
PlayNetwork · Nov 2, 2018 · 45f60f4 · 45f60f4
2 parents 0539881 + 2b37310
commit 45f60f4
Show file tree

Hide file tree

Showing 13 changed files with 63 additions and 62 deletions.
diff --git a/history.md b/history.md
@@ -1,3 +1,7 @@
+# v1.4.5 - 2018/11/02
+
+* Fixed bug in many sub-modules where ensuring authentication headers was called improperly
+
 # v1.4.4 - 2018/10/31
 
 * Fixed bug preventing asset downloads

diff --git a/lib/asset.js b/lib/asset.js
@@ -93,7 +93,7 @@ module.exports = function (assetOptions, ensureAuthHeaders, self) {
 				options.method = options.method.toLowerCase();
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req[options.method]({
 				headers : headers,
@@ -182,7 +182,7 @@ module.exports = function (assetOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('asset is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,

diff --git a/lib/content.js b/lib/content.js
@@ -90,7 +90,7 @@ module.exports = function (contentOptions, ensureAuthHeaders, self) {
 				options.method = options.method.toLowerCase();
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req[options.method]({
 				headers : headers,
@@ -131,7 +131,7 @@ module.exports = function (contentOptions, ensureAuthHeaders, self) {
 
 			let assetId = typeof track === 'string' ? track : track.assetId;
 
-			return ensureAuthHeaders(options)
+			return ensureAuthHeaders()
 				.then((headers) => {
 					req
 						.head({
@@ -177,7 +177,7 @@ module.exports = function (contentOptions, ensureAuthHeaders, self) {
 				return reject(new Error('track is missing identifier'));
 			}
 
-			return ensureAuthHeaders(options)
+			return ensureAuthHeaders()
 				.then((headers) => {
 					req
 						.head({
@@ -229,7 +229,7 @@ module.exports = function (contentOptions, ensureAuthHeaders, self) {
 
 			let assetId = typeof track === 'string' ? track : track.assetId;
 
-			return ensureAuthHeaders(options)
+			return ensureAuthHeaders()
 				.then((headers) => {
 					req
 						.head({
@@ -281,7 +281,7 @@ module.exports = function (contentOptions, ensureAuthHeaders, self) {
 
 			let
 				assetId = typeof track === 'string' ? track : track.assetId,
-				headers = yield ensureAuthHeaders(options);
+				headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -314,7 +314,7 @@ module.exports = function (contentOptions, ensureAuthHeaders, self) {
 
 			let
 				alias = self.buildTrackAlias(track),
-				headers = yield ensureAuthHeaders(options);
+				headers = yield ensureAuthHeaders();
 
 			if (validation.isEmpty(alias)) {
 				return yield Promise.reject(new Error('track is missing identifier'));
@@ -361,7 +361,7 @@ module.exports = function (contentOptions, ensureAuthHeaders, self) {
 
 			let
 				assetId = typeof track === 'string' ? track : track.assetId,
-				headers = yield ensureAuthHeaders(options);
+				headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,

diff --git a/lib/device.js b/lib/device.js
@@ -54,7 +54,7 @@ module.exports = function (deviceOptions, ensureAuthHeaders, self) {
 		}
 
 		let exec = co(function *() {
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -74,7 +74,7 @@ module.exports = function (deviceOptions, ensureAuthHeaders, self) {
 		}
 
 		let exec = co(function *() {
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -252,7 +252,7 @@ module.exports = function (deviceOptions, ensureAuthHeaders, self) {
 		}
 
 		let exec = co(function *() {
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -282,7 +282,7 @@ module.exports = function (deviceOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('deviceId is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -335,7 +335,7 @@ module.exports = function (deviceOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('groupId is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -365,7 +365,7 @@ module.exports = function (deviceOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('groupId is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -395,7 +395,7 @@ module.exports = function (deviceOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('groupId is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,

diff --git a/lib/location.js b/lib/location.js
@@ -52,7 +52,7 @@ module.exports = function (locationOptions, ensureAuthHeaders, self) {
 		}
 
 		let exec = co(function *() {
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -72,7 +72,7 @@ module.exports = function (locationOptions, ensureAuthHeaders, self) {
 		}
 
 		let exec = co(function *() {
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -92,7 +92,7 @@ module.exports = function (locationOptions, ensureAuthHeaders, self) {
 		}
 
 		let exec = co(function *() {
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -125,7 +125,7 @@ module.exports = function (locationOptions, ensureAuthHeaders, self) {
 				options.method = options.method.toLowerCase();
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req[options.method]({
 				headers : headers,
@@ -177,7 +177,7 @@ module.exports = function (locationOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('locationId is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -230,7 +230,7 @@ module.exports = function (locationOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('physicalLocationId is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,

diff --git a/lib/music.js b/lib/music.js
@@ -132,7 +132,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('stationId is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -152,7 +152,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 		}
 
 		let exec = co(function *() {
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -182,7 +182,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('collectionId is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -202,7 +202,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 		}
 
 		let exec = co(function *() {
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -232,7 +232,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('playlistId is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -252,7 +252,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 		}
 
 		let exec = co(function *() {
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -282,7 +282,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('stationId is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -302,7 +302,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 		}
 
 		let exec = co(function *() {
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -335,7 +335,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 				options.method = options.method.toLowerCase();
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req[options.method]({
 				headers : headers,
@@ -413,7 +413,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('stationId is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.post({
 				headers : headers,
@@ -564,7 +564,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('stationId is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -605,7 +605,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('broadcastId is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -635,7 +635,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('collectionId is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -665,7 +665,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('playlistId is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -695,7 +695,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('stationId is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -725,7 +725,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('trackAlias is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,
@@ -760,7 +760,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 			}
 
 			let
-				headers = yield ensureAuthHeaders(options),
+				headers = yield ensureAuthHeaders(),
 				trackAliasList = tracks
 					.map((track) => (buildTrackAlias(track)))
 					.filter((alias) => (!validation.isEmpty(alias)));
@@ -797,7 +797,7 @@ module.exports = function (musicOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('collectionId is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,

diff --git a/lib/playback.js b/lib/playback.js
@@ -62,7 +62,7 @@ module.exports = function (playbackOptions, ensureAuthHeaders, self) {
 				return yield Promise.reject(new Error('key is required'));
 			}
 
-			let headers = yield ensureAuthHeaders(options);
+			let headers = yield ensureAuthHeaders();
 
 			return yield req.get({
 				headers : headers,