Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BMS-375: Add support for Brand API #90

Merged
merged 4 commits into from
Nov 15, 2019
Merged

BMS-375: Add support for Brand API #90

merged 4 commits into from
Nov 15, 2019

Conversation

benjamin-morin
Copy link

http://jira.touchtunes.com/browse/BMS-375

Only a few GET endpoints were implemented for now.

@benjamin-morin benjamin-morin self-assigned this Nov 5, 2019
@coveralls
Copy link

coveralls commented Nov 5, 2019 •
edited

Coverage Status

Coverage remained the same at 1.497% when pulling 1ae6604 on vnext-brand-api into 3d9efe4 on vnext.

badaldesai
badaldesai suggested changes Nov 5, 2019
View reviewed changes
lib/brand.js Outdated Show resolved Hide resolved
lib/brand.js Outdated Show resolved Hide resolved
Mig-OG
Mig-OG approved these changes Nov 6, 2019
View reviewed changes
Copy link

@Mig-OG Mig-OG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

@benjamin-morin
Copy link
Author

Any update on this guys?

@gcerrott gcerrott merged commit a49dbde into vnext Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badaldesai badaldesai badaldesai approved these changes

@gcerrott gcerrott gcerrott approved these changes

@Mig-OG Mig-OG Mig-OG approved these changes

Assignees

@benjamin-morin benjamin-morin

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@benjamin-morin @coveralls @badaldesai @gcerrott @Mig-OG