Enable use on Windows for 3.0.x #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot |
|
There must be something different between your build setup and the AppVeyor build setup to automatically generate a Windows build on each commit since the AppVeyor build still fails with your commit - https://ci.appveyor.com/project/facontidavide59577/plotjuggler/builds/37088449 |
facontidavide
pushed a commit
that referenced
this pull request
Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been created for visibility with regards to #368 and may be merged if desired, or inspected by others curious about running 3.0.x on windows.
As mentioned there, this does not include LSL plugin support, but it does enable the windows build to run under basic functionality. I have not tested UDP streaming or plugins outside DataLoaders (csv and a plugin for a custom format). However, based on the testing I did perform, I did not notice any issues.
For building, I mirrored the environment described in #315.