Refactor SpinifyCommandMixin error handling and connection logic

PlugFox · May 14, 2024 · 1d0494d · 1d0494d
1 parent 5bebdfe
commit 1d0494d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/lib/src/model/command.dart b/lib/src/model/command.dart
@@ -247,10 +247,9 @@ final class SpinifyPingRequest extends SpinifyCommand {
 final class SpinifySendRequest extends SpinifyCommand {
   /// {@macro command}
   const SpinifySendRequest({
-    required super.id,
     required super.timestamp,
     required this.data,
-  });
+  }) : super(id: 0);
 
   @override
   String get type => 'SendRequest';

diff --git a/lib/src/spinify_impl.dart b/lib/src/spinify_impl.dart
@@ -157,7 +157,6 @@ base mixin SpinifyCommandMixin on SpinifyBase {
 
   @override
   Future<void> send(List<int> data) => _sendCommandAsync(SpinifySendRequest(
-        id: _getNextCommandId(),
         timestamp: DateTime.now(),
         data: data,
       ));
@@ -311,7 +310,9 @@ base mixin SpinifyConnectionMixin
   Future<void> connect(String url) async {
     if (state.url == url) return;
     final completer = _readyCompleter ??= Completer<void>();
-    await disconnect();
+    try {
+      await disconnect();
+    } on Object {/* ignore */}
     try {
       _setState(SpinifyState$Connecting(url: url));
       _reconnectUrl = url;
@@ -489,6 +490,8 @@ base mixin SpinifyConnectionMixin
   @override
   Future<void> disconnect() async {
     _reconnectUrl = null;
+    // TODO(plugfox): tear down reconnect timer
+    // tearDownReconnectTimer();
     if (state.isDisconnected) return Future.value();
     await _transport?.disconnect(1000, 'Client disconnecting');
     await _onDisconnected();
@@ -498,7 +501,7 @@ base mixin SpinifyConnectionMixin
   Future<void> _onDisconnected() async {
     _refreshTimer?.cancel();
     _transport = null;
-    // TODO(plugfox): reconnect
+    // TODO(plugfox): setup reconnect if reconnectUrl is not null
     await super._onDisconnected();
   }