Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird html out on a very long post #96

Closed
gled-rs opened this issue Jun 28, 2018 · 3 comments
Closed

Weird html out on a very long post #96

gled-rs opened this issue Jun 28, 2018 · 3 comments
Assignees
@trinity-1686a
Labels
C: Bug Something isn't working
Milestone
Alpha 1

Comments

@gled-rs
Copy link
Contributor

gled-rs commented Jun 28, 2018

See https://plume.mastodon.host/~/Testing1234/how-angry-will-the-admin-get/

We have the csrf token displayed and the end of the post mixed in the comment section.
@elegaanz elegaanz added C: Bug Something isn't working P: Medium labels Jun 28, 2018
@elegaanz elegaanz added this to the Alpha 1 milestone Jun 28, 2018
@elegaanz
Copy link
Member

I can reproduce, but only if logged in. I think there is an issue with your rocket_csrf crate @fdb-hiroshima.

@gled-rs
Copy link
Contributor Author

gled-rs commented Jun 28, 2018

Let me know if you need anything to help chase that bug down.

@trinity-1686a
Copy link
Contributor

trinity-1686a commented Jun 29, 2018 •
edited

I can't get a csrf token being displayed, however I see a nice big block of text repeated like 3 times after the closing </html> tag, so I guess not all browser show this the same way, and this should be enought to try to understand the issue

@trinity-1686a trinity-1686a self-assigned this Jun 29, 2018
trinity-1686a added a commit to Plume-org/rocket_csrf that referenced this issue Jun 30, 2018
@trinity-1686a
Fix a bug on CsrfProxy
13ca47e 
Fix a bug where CsrfProxy would read data that was already present in
read buffer, where it should consider it uninitialized
Reported by @gled-rs on Plume-org/Plume#96
@trinity-1686a trinity-1686a mentioned this issue Oct 24, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trinity-1686a trinity-1686a

Labels
C: Bug Something isn't working
Projects
None yet
Milestone
Alpha 1
Development

No branches or pull requests
3 participants
@gled-rs @elegaanz @trinity-1686a