New forms style #104
Merged
New forms style #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elegaanz
added
C: Enhancement
|
Looking at your screens, it looks really nicer than before. My only concern would be about the centered text in inputs, since the text is moving in a quite strange way when typing like that. But I still should give it a live try. |
elegaanz
reviewed
Jul 1, 2018
There was a problem hiding this comment.
As I said, I'm not sure having text centered in inputs is a good idea.
And I don't know if the textarea to write an article should be that small. Maybe if it has a bigger default height?
Otherwise, it looks very good! Great job! 👌
(and as usual I'm open to discussion if there are good reasons behind these choices)
|
I'm going to merge this and make a few changes after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Login example on phones and register example on a computer.
