New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete notifications when deleting comments #499
Conversation
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
- Coverage 26.89% 26.83% -0.06%
==========================================
Files 65 65
Lines 8966 9000 +34
==========================================
+ Hits 2411 2415 +4
- Misses 6555 6585 +30 |
There is no need to order the notifications
The following changes have been made:
The following use cases were tested:
|
Does this mean it fixes #500 too? |
No. That's another issue. In that issue, mentioning and mentioned user are confused somewhere, I guess. |
It actually looks like this also closes #500. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit weird to receive two notifications for the same comment when you are mentioned in a comment under your own article, but it is not really related to this PR, and otherwise it works great. Thank you. 😊
This PR implements a new function
find_for_comment
onNotification
to list all notifications for a specific comment. Thedelete
function onComment
is changed to list and delete all connected notifications.I wasn't able to test the changes yet since I don't have the test environment set up, so the PR is
WIP
for now.This should close #463 and close #500.