Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache local instance #572

Merged
merged 4 commits into from May 10, 2019
Merged

cache local instance #572

merged 4 commits into from May 10, 2019

Conversation

trinity-1686a
Copy link
Contributor

fix #564

@codecov
Copy link

codecov bot commented May 10, 2019 •
edited

Codecov Report

Merging #572 into master will decrease coverage by 0.2%.
The diff coverage is 36.73%.

@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
- Coverage   34.72%   34.51%   -0.21%     
==========================================
  Files          67       67              
  Lines        7851     7872      +21     
  Branches     1886     1890       +4     
==========================================
- Hits         2726     2717       -9     
- Misses       4367     4394      +27     
- Partials      758      761       +3

@trinity-1686a trinity-1686a added A: Backend Code running on the server S: Ready for review This PR is ready to be reviewed labels May 10, 2019
elegaanz
elegaanz approved these changes May 10, 2019
View reviewed changes
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you.

@elegaanz elegaanz merged commit 773fbfe into master May 10, 2019
@trinity-1686a trinity-1686a deleted the cache-local-instance branch May 11, 2019 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elegaanz elegaanz elegaanz approved these changes

Assignees
No one assigned
Labels
A: Backend Code running on the server S: Ready for review This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cache local instance
2 participants
@trinity-1686a @elegaanz