Fix displaying not found page when submitting a duplicated blocklist email #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…email Signed-off-by: Serra Allgood <serra@allgood.dev>
StarryAster
pushed a commit
to StarryAster/Plume
that referenced
this pull request
Oct 19, 2020
) from gpu-acceleration into main Reviewed-on: https://git.joinplu.me/Plume/Plume/pulls/818 Reviewed-by: kiwii <kiwii@noreply@joinplu.me>
|
I think so, too. |
elegaanz
pushed a commit
that referenced
this pull request
Nov 22, 2020
|
For future contributions, we moved to a self-hosted gitea so we prefer PRs here even if we can merge them "manually" from Github. Anyway, thank you for your help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #754. I'm still new to Rust and even newer to Plume, but I thought this approach made sense. The alternative I thought of was to leverage the
BlocklistedEmail::matches_blocklistfunction, but I thought that approach is unreasonable because it requires loading the entire blocklisted_emails table.