Move secrets to a new file secrets.h add add to gitignore #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k to ntptimeclient.h so it's consistent with the rest of the project (with the exception of secrets)
removes lib/* from this version of .gitignore it's not part of this PR
|
I thought about also moving the NTP address to secrets.h since it's going to be different for different folks. What do you think? |
|
Cool…. So does that have the effect of there’s a “default” secrets.h, which you can edit or replace locally, but when you commit your changes get ignored? Clever!
- Dave
… On Oct 15, 2021, at 2:09 PM, Scott ***@***.***> wrote:
Description
Move secrets, such as Wifi network, and credentials to secrets.h. This file is added to .gitignore.
This should make it so users don't need to worry about publishing their network SSID/password when committing changes.
Also, moves NTP network address to define at top of ntptimeclient.h
Contributing requirements
I read the contribution guidelines in CONTRIBUTING.md <https://github.com/PlummersSoftwareLLC/NightDriverStrip/blob/main/CONTRIBUTING.md>.
I understand the BlinkenPerBit metric, and maximized it in this PR.
I selected main as the target branch.
All code herein is subjected to the license terms in COPYING.txt <https://github.com/PlummersSoftwareLLC/NightDriverStrip/blob/main/COPYING.txt>.
You can view, comment on, or merge this pull request online at:
#47 <#47>
Commit Summary
move secrets to secrets.h <c93da85>
add secrets.h to gitignore, fix some comments and move NTP server back to ntptimeclient.h so it's consistent with the rest of the project (with the exception of secrets) <dd2a9d1>
File Changes
M .gitignore <https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/47/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947> (3)
M include/network.h <https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/47/files#diff-da57893dd99fcb3e1711922d90bafa6f5f9f622a638406680f30f5d0ac2381bd> (5)
M include/ntptimeclient.h <https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/47/files#diff-cb01fa5781e706f3d94785f1fc00f117a62e8e384fedf77668d3d20fbe96981c> (11)
A include/secrets.h <https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/47/files#diff-d2d057e5eae008682473312eea8f7c6604f4ec32469a784a82ddb8ba46d6f2cc> (32)
Patch Links:
https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/47.patch <https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/47.patch>
https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/47.diff <https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/47.diff>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#47>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4HCFZDRVB5E4YELMR2KPDUHCJ7TANCNFSM5GCYT4YA>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Yes, exactly. |
|
Nicely done, thanks! |
Man, I am super embarrassed. git update-index --assume-unchanged include/secrets.h |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move secrets, such as Wifi network, and credentials to secrets.h. This file is added to .gitignore.
This should make it so users don't need to worry about publishing their network SSID/password when committing changes.
Also, moves NTP network address to define at top of ntptimeclient.h
Contributing requirements
mainas the target branch.