Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX updated Atracsys cmake to align with SDK changes #93

Closed
wants to merge 1 commit into from

Conversation

atracsys-sbt
Copy link
Contributor

Atracsys has changed its SDK inclusion via CMake. The following PR reflects these changes.
I have also changed some of the comments to be more inclusive to the fusionTrack.

@Sunderlandkyl
Copy link
Contributor

Can you add back the PLTools path hints to FindAtracsysSDK? It is used by our build machines to compile Plus without installing SDKs.

@atracsys-sbt
Copy link
Contributor Author

I added back the PLTools path hints.

@Sunderlandkyl
Copy link
Contributor

I don't think the path hints are being used anymore. Can you update FindAtracsysSDK.cmake so that it will check for the SDK in PLTools?

@atracsys-sbt
Copy link
Contributor Author

I'm a bit confused, in my last commit I added the path hints as you requested so that PLTools would find the SDK. I'm not sure what else I should do to facilitate the SDK check in PLTools (platform which I don't have any knowledge of).
Could you please be a bit more specific ? Thanks

@Sunderlandkyl
Copy link
Contributor

Sunderlandkyl commented Oct 5, 2023

In the previous version, the SDK was searched for using the path hints, to find the location of "include/ftkTypes.h":

find_path(ATRACSYS_SDK_DIR include/ftkTypes.h
  PATHS ${ATRACSYS_SDK_PATH_HINTS}
  DOC "Atracsys SDK directory." )

The desired behavior is that if we have a PLTools folder, we should check there first to set ATRACSYS_DIR, before looking for the installed SDK. Probably this can be done by adding ${ATRACSYS_SDK_INSTALL_PATH} to the path hints after PLTools, and using this to set ATRACSYS_DIR:

find_path(ATRACSYS_DIR cmake/Atracsys/AtracsysConfig.cmake"
  PATHS ${ATRACSYS_SDK_PATH_HINTS}
  DOC "Atracsys directory." )

PLTools is just a version-controlled folder containing SDKs for all of the different devices that we use. I can adjust the directories to search for the SDK in PLTools, so don't worry about the exact path.

- Changed variables names to avoid warning during config
- Moved path_hints to prioritize PLtools
@atracsys-sbt
Copy link
Contributor Author

Ok, it should finally work (it does on my machine). The PLtools path hints are set before checking for the installed SDK. Also, I changed the name of the cmake Atracsys variables to avoid a Warning during cmake configuration. There is a PlusLib PR related to the current PR, which should get merged simultaneously.

@Sunderlandkyl
Copy link
Contributor

Thanks! I added the hints to find_package. Changes integrated in 8a693d2 and 709b11c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants