Skip to content

Commit

Permalink
Resolve TODOs, clarify what node refers to
Browse files Browse the repository at this point in the history
  • Loading branch information
aske committed May 29, 2023
1 parent 538faf7 commit 5d35455
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions doc/plutip-testing.md
Expand Up @@ -210,10 +210,7 @@ This functionality will probably be added to CTL later.

### Note on SIGINT

<!-- TODO: clarify which node is meant here -- node.js or cardano-node? -->
<!-- TODO: why does the CTL project template restore the default behavior? -->

Due to `testPlutipContracts`/`runPlutipContract` adding listeners to the SIGINT signal, node's default behaviour of exiting on that signal no longer occurs. This was done to add cleanup handlers and let them run in parallel instead of exiting eagerly, which is possible when running multiple clusters in parallel. To restore the exit behaviour, we provide helpers to cancel an `Aff` fiber and set the exit code, to let node shut down gracefully when no more events are to be processed.
Due to `testPlutipContracts`/`runPlutipContract` adding listeners to the SIGINT signal, Node.js's default behaviour of exiting on that signal no longer occurs. This was done to add cleanup handlers and let them run in parallel instead of exiting eagerly, which is possible when running multiple clusters in parallel. To restore the exit behaviour, we provide helpers to cancel an `Aff` fiber and set the exit code, to let Node.js shut down gracefully when no more events are to be processed.

```purescript
...
Expand Down

0 comments on commit 5d35455

Please sign in to comment.