New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Blockfrost test runner interface #1425
Add Blockfrost test runner interface #1425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor changes but approving to save the review roundtrip
src/Contract/Test/Blockfrost.purs
Outdated
-- | | ||
-- | - Private payment and (optionally) stake keys | ||
-- | - A directory to store temporary private keys that will be used in tests. | ||
-- | In case of a suddent test interruption, funds will not be lost since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-- | In case of a suddent test interruption, funds will not be lost since | |
-- | In case of a sudden test interruption, funds will not be lost since |
src/Internal/Wallet/KeyFile.purs
Outdated
try action >>= either | ||
( \err -> do | ||
liftEffect $ throw $ | ||
"Unable to load key from file: " <> show filePath | ||
<> ", error: " | ||
<> show err | ||
) | ||
pure | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not criticial
try action >>= either | |
( \err -> do | |
liftEffect $ throw $ | |
"Unable to load key from file: " <> show filePath | |
<> ", error: " | |
<> show err | |
) | |
pure | |
catchError action | |
\err -> do | |
liftEffect $ throw $ | |
"Unable to load key from file: " <> show filePath | |
<> ", error: " | |
<> show err |
Closes #1420
Pre-review checklist
make format
)## Unreleased
header, using the appropriate sub-headings (### Added
,### Removed
,### Fixed
), and the links to the appropriate issues/PRs have been included