Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blockfrost test runner interface #1425

Conversation

klntsky
Copy link
Member

@klntsky klntsky commented Jan 31, 2023

Closes #1420

Pre-review checklist

  • All code has been formatted using our config (make format)
  • Any new API features or modification of existing behavior is covered as defined in our test plan
  • The changelog has been updated under the ## Unreleased header, using the appropriate sub-headings (### Added, ### Removed, ### Fixed), and the links to the appropriate issues/PRs have been included

@klntsky klntsky changed the base branch from develop to dshuiski/1119-query-backend January 31, 2023 16:49
@klntsky klntsky requested a review from jy14898 February 1, 2023 09:54
Copy link
Collaborator

@jy14898 jy14898 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor changes but approving to save the review roundtrip

-- |
-- | - Private payment and (optionally) stake keys
-- | - A directory to store temporary private keys that will be used in tests.
-- | In case of a suddent test interruption, funds will not be lost since
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- | In case of a suddent test interruption, funds will not be lost since
-- | In case of a sudden test interruption, funds will not be lost since

Comment on lines 57 to 65
try action >>= either
( \err -> do
liftEffect $ throw $
"Unable to load key from file: " <> show filePath
<> ", error: "
<> show err
)
pure

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not criticial

Suggested change
try action >>= either
( \err -> do
liftEffect $ throw $
"Unable to load key from file: " <> show filePath
<> ", error: "
<> show err
)
pure
catchError action
\err -> do
liftEffect $ throw $
"Unable to load key from file: " <> show filePath
<> ", error: "
<> show err

@klntsky klntsky merged commit 198c4f2 into dshuiski/1119-query-backend Feb 7, 2023
@klntsky klntsky deleted the klntsky/add-blockfrost-test-runner-interface branch February 7, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a generic test runner for Blockfrost-based tests
2 participants