Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add faq.md #795

Merged
merged 3 commits into from Jul 29, 2022
Merged

Add faq.md #795

merged 3 commits into from Jul 29, 2022

Conversation

klntsky
Copy link
Member

@klntsky klntsky commented Jul 27, 2022

No description provided.

ngua
ngua reviewed Jul 28, 2022
View reviewed changes
Copy link
Contributor

@ngua ngua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might suggest changing the document name/title to faq.md

@klntsky
Copy link
Member Author

klntsky commented Jul 28, 2022 •
edited

OK sounds less frightening

@firefrorefiddle
Copy link
Contributor

I might suggest changing the document name/title to faq.md

Then the contents should be rephrased as questions.

@klntsky klntsky requested a review from ngua July 29, 2022 12:43
jy14898
jy14898 approved these changes Jul 29, 2022
View reviewed changes
Copy link
Collaborator

@jy14898 jy14898 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as the comments have been addressed

@klntsky klntsky changed the title Add caveats.md Add faq.md Jul 29, 2022
@klntsky klntsky merged commit 71b67b6 into develop Jul 29, 2022
@klntsky klntsky deleted the klntsky/caveats branch November 16, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jy14898 jy14898 jy14898 approved these changes

@errfrom errfrom Awaiting requested review from errfrom

@firefrorefiddle firefrorefiddle Awaiting requested review from firefrorefiddle

@Luis-omega Luis-omega Awaiting requested review from Luis-omega

@ngua ngua Awaiting requested review from ngua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@klntsky @firefrorefiddle @jy14898 @ngua