Basic scattered cleanup #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TotallyNotChase
requested review from
blamario,
srid and
L-as
and removed request for
blamario,
srid and
L-as
Merged
blamario
reviewed
Jan 18, 2022
| @@ -105,7 +107,7 @@ mapTerm f (TermResult t d) = TermResult (f t) d | |||
| mkTermRes :: RawTerm -> TermResult | |||
| mkTermRes r = TermResult r [] | |||
|
|
|||
| -- | Type of `s`. | |||
| -- | Type of `s` in `Term s a`. See: "What is the `s`?" section on the Plutarch guide. | |||
There was a problem hiding this comment.
on -> in
Do we have a stable link for the Plutarch guide?
There was a problem hiding this comment.
I suppose we should consider the one on master stable until we set up a website
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for jumbling a bunch of cleanup into a singular commit. I generally try to avoid that but oh well. This takes care of a bunch of the review comments from #99 - mostly just the basic stuff though.