Shrinker integration and unused dependency removal #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MatthewCroughan Why is the CI not running for this PR? EDIT: Is it to do with the PR being from a branch outside this repo? |
|
@srid yes, currently there is no automated way for forks to submit PRs which will run on our machines. However, there are two workarounds which are detailed here: hercules-ci/support#10 (comment) |
srid
reviewed
Jan 5, 2022
| @@ -60,6 +61,8 @@ outputFilePath :: O.Parser (Maybe OutputFilePath) | |||
| outputFilePath = | |||
| O.argument (Just . OutputFilePath <$> O.str) (O.metavar "OUTPUT" <> O.value Nothing <> O.help "The output file path: defaults to stdout") | |||
|
|
|||
| shrinking :: O.Parser Bool | |||
| shrinking = O.switch (O.long "shrinking" <> O.short 's' <> O.help "Shrink the uplc before serializing (only affects the assemble command)") | |||
There was a problem hiding this comment.
I think it would be useful to respect --shrinking flag on run and eval commands too.
There was a problem hiding this comment.
That makes sense. I'll get to work on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the playground and plutus-pab dependencies cause they don't seem to be used, and I integrated shrinker from the Plutonomicon/Shrinker repo.