Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine_magic problems #270

Closed
moonshoes87 opened this issue Dec 3, 2017 · 2 comments
Closed

combine_magic problems #270

moonshoes87 opened this issue Dec 3, 2017 · 2 comments
Assignees

Comments

@moonshoes87
Copy link
Member

Lisa's issue Archaeomag_3

Step 1.3 combine_magic

something_specimens.txt
specimens.txt

Doesn't append nicely. Stub values.

When you go back to run step 1 a second or third time, things get weird.

A row with just specimen, sample can be dropped if there is another row.

@moonshoes87 moonshoes87 self-assigned this Dec 3, 2017
@ltauxe
Copy link
Member

ltauxe commented Dec 4, 2017

Also, combine_magic.py doesn't seem to work at all on the command line.

@moonshoes87
Copy link
Member Author

@ltauxe, here's an update on combine_magic.

First, the bug in Thellier GUI that we thought was due to combine_magic issues actually is from a pandas bug which will be fixed eventually. In the meantime, I wrote in a workaround to prevent the pandas bug from crashing Thellier GUI.

Second, combine_magic still works on the command line for me.

screen shot 2017-12-05 at 12 23 26 pm

If it isn't working on the command line for you, could you send me the error message that you're seeing?

Last, I've added functionality so that combine_magic drops rows that are probably useless (rows where index is not unique AND no values but name/citations/magic_software are filled out). This should make it much more reasonable to run and rerun combine_magic. Try this out and see if the workflow feels more reasonable.

@moonshoes87 moonshoes87 assigned ltauxe and unassigned moonshoes87 Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants