fix: keep image orientation in thumbnail transformation #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
camillemonchicourt
requested review from
amandine-sahl,
Pierre-Narcisi and
joelclems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nous sommes tombés sur un cas, où en tentant d'upload une image portrait directement depuis l'API GN, les thumbnails se retrouvaient "rotatés" de 90°.
De ce que j'en comprends c'est une metadata EXIF de la photo qui dit "orientation = 3" et la librairie PIL considère que le vrai sens de l'image est 0, PIL va alors "rotater" l'image de 90° (ou 270°, mais bref).
Je peux essayer de vous fournir des images tests, mais cette metadata semble sauter en cas de transfert du fichier via messagerie ou outil de conversation instantané...
Le fix que je propose résout bien le soucis, j'ai aussi testé avec des images PNG qui n'ont pas d'EXIF, et pas d'erreur de la part de l'API. Il y a peut être d'autres edge cases auxquels je n'ai pas pensé.
Issue correspondant à mon cas d'usage côté PIL : python-pillow/Pillow#4703