Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ESLint, Prettier and Cypress configs #107

Merged
merged 3 commits into from
Nov 19, 2022
Merged

fix: ESLint, Prettier and Cypress configs #107

merged 3 commits into from
Nov 19, 2022

Conversation

RezaRahemtola
Copy link
Sponsor Member

@RezaRahemtola RezaRahemtola commented Nov 13, 2022 •
edited

Description

  • ESLint config updated to lint tests files too with a working tsconfig
  • Prettier removed as ESLint rule (for performance issues and better developer experience)
  • A few useless or wrong ESLint rules removed

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functionals / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

@RezaRahemtola RezaRahemtola added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 13, 2022
@RezaRahemtola RezaRahemtola self-assigned this Nov 13, 2022
EdenComp
EdenComp reviewed Nov 14, 2022
View reviewed changes
.eslintrc.yaml Show resolved Hide resolved
.eslintrc.yaml Show resolved Hide resolved
.eslintrc.yaml Show resolved Hide resolved
@RezaRahemtola RezaRahemtola merged commit 01ab26a into dev Nov 19, 2022
@RezaRahemtola RezaRahemtola deleted the fix/eslint branch November 19, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdenComp EdenComp EdenComp left review comments

@lucas-louis lucas-louis lucas-louis approved these changes

@SloWayyy SloWayyy SloWayyy approved these changes

Assignees

@RezaRahemtola RezaRahemtola

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RezaRahemtola @EdenComp @lucas-louis @SloWayyy