Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Configuration on account page #124

Merged
merged 46 commits into from
Mar 19, 2023
Merged

feat: Configuration on account page #124

merged 46 commits into from
Mar 19, 2023

Conversation

EdenComp
Copy link
Contributor

@EdenComp EdenComp commented Mar 2, 2023 •
edited by RezaRahemtola

Description

This PR adds a second card under the Account card, the Configuration page.
It replaces the old component ConfigPage

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functionals / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

Additional comments

There is currently some problems with the theme: will investigate

@EdenComp EdenComp added the enhancement New feature or request label Mar 2, 2023
@netlify
Copy link

netlify bot commented Mar 2, 2023 •
edited

✅ Deploy Preview for nimble-praline-605cf6 ready!

Name Link
🔨 Latest commit 1677cfa
🔍 Latest deploy log https://app.netlify.com/sites/nimble-praline-605cf6/deploys/640112a5ce6f3700082a7ace
😎 Deploy Preview https://deploy-preview-124--nimble-praline-605cf6.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@EdenComp EdenComp changed the base branch from master to feat/dashboard-UI-refactor March 2, 2023 21:20
@RezaRahemtola RezaRahemtola changed the base branch from feat/dashboard-UI-refactor to dev March 2, 2023 21:42
RezaRahemtola
RezaRahemtola requested changes Mar 2, 2023
View reviewed changes
Copy link
Sponsor Member

@RezaRahemtola RezaRahemtola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The global design is here but the values are missing.

Don't forget to handle responsive and keep future configuration options in mind 👍

src/components/account/ConfigCard.tsx Outdated Show resolved Hide resolved
pages/drive/account.tsx Outdated Show resolved Hide resolved
pages/drive/account.tsx Outdated Show resolved Hide resolved
src/components/ConfigPage.tsx Outdated Show resolved Hide resolved
@PoCInnovation PoCInnovation deleted a comment from netlify bot Mar 2, 2023
RezaRahemtola
RezaRahemtola requested changes Mar 17, 2023
View reviewed changes
Copy link
Sponsor Member

@RezaRahemtola RezaRahemtola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing locally I can't edit the configuration options (except for the light/dark theme), which was possible before.

@RezaRahemtola RezaRahemtola marked this pull request as ready for review March 18, 2023 17:23
lucas-louis
lucas-louis approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@lucas-louis lucas-louis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RezaRahemtola RezaRahemtola changed the title Draft: feat: Configuration on account page feat: Configuration on account page Mar 19, 2023
@RezaRahemtola RezaRahemtola merged commit 579dc3b into dev Mar 19, 2023
@RezaRahemtola RezaRahemtola deleted the feat_settings branch March 19, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RezaRahemtola RezaRahemtola RezaRahemtola approved these changes

@lucas-louis lucas-louis lucas-louis approved these changes

Assignees

@EdenComp EdenComp

@SloWayyy SloWayyy

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 7 - Front end uniformization
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EdenComp @RezaRahemtola @lucas-louis @SloWayyy